fix: multilevel permissions in can() method#1229
Closed
bgeneto wants to merge 7 commits intocodeigniter4:developfrom
bgeneto:multilevel-permissions
Closed
fix: multilevel permissions in can() method#1229bgeneto wants to merge 7 commits intocodeigniter4:developfrom bgeneto:multilevel-permissions
bgeneto wants to merge 7 commits intocodeigniter4:developfrom
bgeneto:multilevel-permissions
Conversation
refactor authorization checks to support nested permissions in can()
added !empty() so it returns bool and passes phpstan
bgeneto
commented
Nov 13, 2024
added space after !
refactor authorization checks to support nested permissions in can()
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor authorization checks to support nested permissions in can() method.
Fixes #1224
Description
Changes
Example
Given permission
admin.settings.theme.*:admin.settings.theme,admin.settings.theme.color,admin.settings.theme.layout.darkadmin.settings,admin.*Benefits
Testing
Added comprehensive test cases covering:
Checklist: